The following document contains the results of PMD 4.2.5.
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 42 - 47 |
| Violation | Line |
|---|---|
| Do not add empty strings | 22 |
| The String literal "WHERE fc.identifier.sha1 = :sha1" appears 4 times in this file; the first occurrence is on line 24 | 24 |
| Do not add empty strings | 27 |
| The String literal "WHERE fc.identifier.md5 = :md5" appears 4 times in this file; the first occurrence is on line 29 | 29 |
| Do not add empty strings | 32 |
| The String literal "WHERE fc.identifier.sha1 = :sha1 AND fc.identifier.md5 = :md5" appears 4 times in this file; the first occurrence is on line 34 | 34 |
| Do not add empty strings | 39 |
| Do not add empty strings | 44 |
| Do not add empty strings | 49 |
| Do not add empty strings | 56 |
| Do not add empty strings | 61 |
| Do not add empty strings | 66 |
| Do not add empty strings | 73 |
| Do not add empty strings | 78 |
| Do not add empty strings | 83 |
| Do not add empty strings | 90 |
| Do not add empty strings | 95 |
| Do not add empty strings | 100 |
| Do not add empty strings | 107 |
| It is a good practice to call super() in a constructor | 123 - 124 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 30 - 31 |
| The user-supplied array 'sha1' is stored directly. | 63 |
| The user-supplied array 'md5' is stored directly. | 79 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 30 - 31 |
| It is a good practice to call super() in a constructor | 42 - 44 |
| Overriding method merely calls super | 53 - 55 |
| The user-supplied array 'tags' is stored directly. | 119 |
| Violation | Line |
|---|---|
| Do not add empty strings | 20 |
| It is a good practice to call super() in a constructor | 37 - 38 |
| These nested if statements could be combined | 65 - 66 |
| Violation | Line |
|---|---|
| Do not add empty strings | 22 |
| Do not add empty strings | 28 |
| Do not add empty strings | 32 |
| Do not add empty strings | 36 |
| Do not add empty strings | 40 |
| Do not add empty strings | 45 |
| The String literal "SELECT f.id.source.sourceInformation.publicGUID FROM FILE_CONTENT_SOURCES f " appears 4 times in this file; the first occurrence is on line 46 | 46 |
| Do not add empty strings | 50 |
| Do not add empty strings | 54 |
| Do not add empty strings | 58 |
| Violation | Line |
|---|---|
| Do not add empty strings | 25 |
| Do not add empty strings | 29 |
| Do not add empty strings | 33 |
| Do not add empty strings | 37 |
| Do not add empty strings | 41 |
| It is a good practice to call super() in a constructor | 58 - 59 |
| Overriding method merely calls super | 123 - 125 |
| Violation | Line |
|---|---|
| Do not add empty strings | 18 |
| Violation | Line |
|---|---|
| Do not add empty strings | 20 |
| Do not add empty strings | 27 |
| Do not add empty strings | 34 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 25 - 26 |
| Violation | Line |
|---|---|
| Do not add empty strings | 28 |
| Do not add empty strings | 35 |
| Do not add empty strings | 42 |
| The String literal "SELECT pf.id.fileName, pf.id.fileDetails.identifier FROM PACKAGE_FILES pf " appears 4 times in this file; the first occurrence is on line 43 | 43 |
| Do not add empty strings | 47 |
| Do not add empty strings | 52 |
| Do not add empty strings | 58 |
| Do not add empty strings | 64 |
| Do not add empty strings | 69 |
| Do not add empty strings | 74 |
| Do not add empty strings | 79 |
| Do not add empty strings | 85 |
| The String literal "WHERE p.packageFileDetails = pf.id.fileDetails AND " appears 5 times in this file; the first occurrence is on line 87 | 87 |
| Do not add empty strings | 93 |
| The String literal "SELECT p.packageInformation.name FROM PACKAGE_FILES pf, PACKAGES p " appears 4 times in this file; the first occurrence is on line 94 | 94 |
| Do not add empty strings | 99 |
| Do not add empty strings | 105 |
| Do not add empty strings | 112 |
| Do not add empty strings | 120 |
| The String literal "SELECT p.packageInformation, p.packageFileDetails.information FROM PACKAGES p " appears 4 times in this file; the first occurrence is on line 121 | 121 |
| Do not add empty strings | 125 |
| Do not add empty strings | 130 |
| Do not add empty strings | 136 |
| Do not add empty strings | 144 |
| The String literal "SELECT p.id FROM PACKAGES p " appears 4 times in this file; the first occurrence is on line 145 | 145 |
| Do not add empty strings | 149 |
| Do not add empty strings | 154 |
| Do not add empty strings | 162 |
| It is a good practice to call super() in a constructor | 178 - 179 |
| Violation | Line |
|---|---|
| Do not add empty strings | 26 |
| Do not add empty strings | 31 |
| Do not add empty strings | 36 |
| Do not add empty strings | 39 |
| It is a good practice to call super() in a constructor | 51 - 52 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 38 - 39 |
| Overridable method 'validateAndSetNames' called during object construction | 44 |
| The user-supplied array 'tags' is stored directly. | 129 |
| Violation | Line |
|---|---|
| Do not add empty strings | 24 |
| Do not add empty strings | 28 |
| Do not add empty strings | 32 |
| The String literal "WHERE s.sourceInformation.publicGUID = :publicGUID" appears 4 times in this file; the first occurrence is on line 34 | 34 |
| Do not add empty strings | 38 |
| Do not add empty strings | 44 |
| Do not add empty strings | 50 |
| Do not add empty strings | 54 |
| It is a good practice to call super() in a constructor | 66 - 67 |
| Violation | Line |
|---|---|
| Do not add empty strings | 25 |
| Do not add empty strings | 28 |
| Do not add empty strings | 34 |
| It is a good practice to call super() in a constructor | 48 - 49 |
| Overridable method 'setPrimaryKey' called during object construction | 58 |
| Overridable method 'getPrimaryKey' called during object construction | 58 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 28 - 29 |
| The user-supplied array 'hash' is stored directly. | 51 |
| Violation | Line |
|---|---|
| Do not add empty strings | 29 |
| Do not add empty strings | 34 |
| Do not add empty strings | 39 |
| It is a good practice to call super() in a constructor | 50 - 51 |
| Violation | Line |
|---|---|
| The String literal "name" appears 7 times in this file; the first occurrence is on line 133 | 133 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 34 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 97 - 98 |
| Violation | Line |
|---|---|
| The String literal "publicGUID" appears 8 times in this file; the first occurrence is on line 132 | 132 |
| Avoid throwing raw exception types. | 305 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 47 - 58 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 40 - 46 |
| Violation | Line |
|---|---|
| Avoid throwing raw exception types. | 42 |
| Overridable method 'loadQueue' called during object construction | 60 |
| Avoid throwing raw exception types. | 159 |
| Avoid throwing raw exception types. | 172 |
| Violation | Line |
|---|---|
| It is somewhat confusing to have a field name with the same name as a method | 26 |
| Violation | Line |
|---|---|
| It is somewhat confusing to have a field name with the same name as a method | 21 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 22 - 23 |
| clone() method should throw CloneNotSupportedException | 34 - 36 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 62 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 72 |
| Avoid throwing raw exception types. | 237 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 265 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 265 |
| Avoid throwing raw exception types. | 283 |