The following document contains the results of PMD 4.2.5.
| Violation | Line |
|---|---|
| This final field could be made static | 105 |
| Avoid unused private fields such as 'productionMode'. | 105 |
| Avoid unused private fields such as 'enableAuthInHttp'. | 106 |
| Violation | Line |
|---|---|
| This abstract class does not have any abstract methods | 14 - 50 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 22 - 23 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 35 |
| Avoid using short method names | 44 |
| Avoid using short method names | 55 |
| Avoid using short method names | 66 |
| It is a good practice to call super() in a constructor | 185 - 188 |
| It is a good practice to call super() in a constructor | 194 - 200 |
| It is a good practice to call super() in a constructor | 202 - 205 |
| Violation | Line |
|---|---|
| Overridable method 'setElements' called during object construction | 51 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 53 - 54 |
| Overridable method 'localize' called during object construction | 58 |
| clone() method should throw CloneNotSupportedException | 103 - 105 |
| Violation | Line |
|---|---|
| Overridable method 'setChildCategories' called during object construction | 34 |
| clone() method should throw CloneNotSupportedException | 53 - 66 |
| Avoid throwing raw exception types. | 64 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 60 - 61 |
| Overridable method 'setStartDate' called during object construction | 65 |
| Overridable method 'setEndDate' called during object construction | 66 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 34 - 35 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 27 - 28 |
| Overriding method merely calls super | 65 - 67 |
| Violation | Line |
|---|---|
| The user-supplied array 'sha1' is stored directly. | 106 |
| The user-supplied array 'md5' is stored directly. | 106 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 45 - 46 |
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'metadata'. | 80 - 93 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 32 - 33 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 25 - 26 |
| Overriding method merely calls super | 64 - 66 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 25 - 26 |
| Overriding method merely calls super | 63 - 65 |
| Violation | Line |
|---|---|
| Overridable method 'convertURIsToPlainASCII' called during object construction | 60 |
| Overridable method 'ensureIdentifierIsSetAndValid' called during object construction | 61 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 28 - 29 |
| Overriding method merely calls super | 66 - 68 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 27 - 28 |
| Overriding method merely calls super | 65 - 67 |
| Violation | Line |
|---|---|
| Avoid throwing raw exception types. | 44 |
| Overridable method 'setSHA1Hash' called during object construction | 83 |
| Overridable method 'setSHA1Hash' called during object construction | 83 |
| Overridable method 'setSHA1Hash' called during object construction | 83 |
| Overridable method 'setSHA1Hash' called during object construction | 100 |
| Overridable method 'setSHA1Hash' called during object construction | 100 |
| Overridable method 'setSHA1Hash' called during object construction | 100 |
| Overridable method 'setSHA1Hash' called during object construction | 104 |
| Overridable method 'setSHA1Hash' called during object construction | 104 |
| Overridable method 'setSHA1Hash' called during object construction | 104 |
| The user-supplied array 'sha1' is stored directly. | 111 |
| Avoid throwing raw exception types. | 133 |
| Violation | Line |
|---|---|
| Overridable method 'assertIsValid' called during object construction | 47 |
| Violation | Line |
|---|---|
| It is somewhat confusing to have a field name matching the declaring class name | 38 |
| Overridable method 'setUsageStatisticsCollection' called during object construction | 58 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 28 - 29 |
| Overriding method merely calls super | 66 - 68 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 19 - 20 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 30 - 31 |
| The user-supplied array 'requiredRoles' is stored directly. | 37 |
| The user-supplied array 'actualRoles' is stored directly. | 37 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 15 - 43 |
| Violation | Line |
|---|---|
| The String literal "packageDetails" appears 4 times in this file; the first occurrence is on line 68 | 68 |
| Violation | Line |
|---|---|
| The String literal "jobGUID" appears 16 times in this file; the first occurrence is on line 43 | 43 |
| The String literal "contentIdentifier" appears 4 times in this file; the first occurrence is on line 155 | 155 |
| The String literal "sourceIdentifier" appears 4 times in this file; the first occurrence is on line 185 | 185 |
| The String literal "job" appears 4 times in this file; the first occurrence is on line 456 | 456 |
| Violation | Line |
|---|---|
| The String literal "locale" appears 4 times in this file; the first occurrence is on line 39 | 39 |
| Violation | Line |
|---|---|
| The String literal "locale" appears 5 times in this file; the first occurrence is on line 43 | 43 |
| The String literal "categoryName" appears 5 times in this file; the first occurrence is on line 92 | 92 |
| The String literal "fileId" appears 4 times in this file; the first occurrence is on line 137 | 137 |
| The String literal "pageNumber" appears 4 times in this file; the first occurrence is on line 141 | 141 |
| The String literal "names" appears 8 times in this file; the first occurrence is on line 207 | 207 |
| Violation | Line |
|---|---|
| The String literal "text/plain" appears 6 times in this file; the first occurrence is on line 80 | 80 |
| The String literal "sha1OrMd5" appears 5 times in this file; the first occurrence is on line 83 | 83 |
| The String literal "sha1" appears 5 times in this file; the first occurrence is on line 102 | 102 |
| The String literal "md5" appears 5 times in this file; the first occurrence is on line 102 | 102 |
| Violation | Line |
|---|---|
| The String literal "file" appears 14 times in this file; the first occurrence is on line 45 | 45 |
| The String literal "result" appears 4 times in this file; the first occurrence is on line 145 | 145 |
| The String literal "tag" appears 5 times in this file; the first occurrence is on line 149 | 149 |
| Violation | Line |
|---|---|
| The String literal "pageNumber" appears 12 times in this file; the first occurrence is on line 71 | 71 |
| The String literal "text/plain" appears 5 times in this file; the first occurrence is on line 85 | 85 |
| The String literal "sha1OrMd5" appears 6 times in this file; the first occurrence is on line 196 | 196 |
| The String literal "packageName" appears 6 times in this file; the first occurrence is on line 218 | 218 |
| Violation | Line |
|---|---|
| The String literal "pageNumber" appears 13 times in this file; the first occurrence is on line 42 | 42 |
| The String literal "name" appears 4 times in this file; the first occurrence is on line 56 | 56 |
| The String literal "packageNames" appears 6 times in this file; the first occurrence is on line 112 | 112 |
| The String literal "result" appears 8 times in this file; the first occurrence is on line 145 | 145 |
| The String literal "file" appears 4 times in this file; the first occurrence is on line 148 | 148 |
| The String literal "tag" appears 9 times in this file; the first occurrence is on line 149 | 149 |
| The String literal "packageName" appears 12 times in this file; the first occurrence is on line 238 | 238 |
| The String literal "packageFileId" appears 7 times in this file; the first occurrence is on line 429 | 429 |
| The String literal "packageInfo" appears 4 times in this file; the first occurrence is on line 490 | 490 |
| The String literal "packageDetails" appears 4 times in this file; the first occurrence is on line 596 | 596 |
| Violation | Line |
|---|---|
| The String literal "localhost" appears 4 times in this file; the first occurrence is on line 73 | 73 |
| Violation | Line |
|---|---|
| The String literal "sourceIdentifier" appears 9 times in this file; the first occurrence is on line 45 | 45 |
| The String literal "pageNumber" appears 6 times in this file; the first occurrence is on line 46 | 46 |
| The String literal "remoteSourceURL" appears 4 times in this file; the first occurrence is on line 100 | 100 |
| The String literal "sourceInformation" appears 4 times in this file; the first occurrence is on line 111 | 111 |
| The String literal "sourceDomain" appears 4 times in this file; the first occurrence is on line 300 | 300 |